Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add "404 - Not found" page #1520

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat(frontend): Add "404 - Not found" page #1520

merged 1 commit into from
Apr 29, 2024

Conversation

MoritzWeber0
Copy link
Member

No description provided.

Copy link

github-actions bot commented Apr 19, 2024

A Storybook preview is available for commit 4836fee.
View Storybook
View Chromatic build

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (50e2cf3) to head (1aa3d29).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   76.94%   78.22%   +1.28%     
==========================================
  Files         170      172       +2     
  Lines        5668     6204     +536     
  Branches      650      731      +81     
==========================================
+ Hits         4361     4853     +492     
- Misses       1161     1186      +25     
- Partials      146      165      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is only one suggestion that you can include if you want to.

frontend/src/app/general/404/404.component.html Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 49e4215 into main Apr 29, 2024
28 checks passed
@MoritzWeber0 MoritzWeber0 deleted the 404-page branch April 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants