Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable persistent workspace sessions for specific tools #1522

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Apr 22, 2024

Some tools can't handle persistent workspaces. Instead, they only support read-only sessions.

Copy link

github-actions bot commented Apr 22, 2024

A Storybook preview is available for commit 428823f.
View Storybook
View Chromatic build

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.30%. Comparing base (cf9c710) to head (41398d6).

Files Patch % Lines
...pellacollab/sessions/hooks/persistent_workspace.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
+ Coverage   78.28%   78.30%   +0.02%     
==========================================
  Files         171      171              
  Lines        5751     5763      +12     
  Branches      660      661       +1     
==========================================
+ Hits         4502     4513      +11     
+ Misses       1099     1098       -1     
- Partials      150      152       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a short PR description why this change is necessary. Other than that, there are only two comments that would be great to address, and then this can be merged.

@MoritzWeber0 MoritzWeber0 force-pushed the disable-workspace-mounting-for-tools branch 4 times, most recently from d8767b2 to 7c82264 Compare April 29, 2024 11:50
@MoritzWeber0 MoritzWeber0 force-pushed the disable-workspace-mounting-for-tools branch from 7c82264 to 41398d6 Compare April 29, 2024 11:52
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 23bcfa8 into main Apr 29, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the disable-workspace-mounting-for-tools branch April 29, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants