Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cascading deletion of tool natures & versions #1528

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

MoritzWeber0
Copy link
Member

When deleting a tool, versions and natures were not deleted. This commit cleans up orphan versions and natures and adds cascading deletion for future tool deletions.

When deleting a tool, versions and natures were not deleted.
This commit cleans up orphan versions and natures and adds cascading deletion
for future tool deletions.
Copy link

github-actions bot commented Apr 25, 2024

A Storybook preview is available for commit e63ee25.
View Storybook
View Chromatic build

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (b844c3f) to head (1bb7963).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1528   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files         171      171           
  Lines        5708     5708           
  Branches      650      650           
=======================================
  Hits         4455     4455           
  Misses       1104     1104           
  Partials      149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MoritzWeber0 MoritzWeber0 merged commit 6a4564b into main Apr 29, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the delete-versions-on-tool-deletion branch April 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants