Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to Angular standalone components #1534

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

dominik003
Copy link
Contributor

This migratee the frontend components to standalone components. This is required for Storybook to use components, but also removes the need for the @NgModule inside the app modules file. The changes here were mostly done automatically using the Standalone Migration CLI.

Copy link

github-actions bot commented Apr 29, 2024

A Storybook preview is available for commit 405f64e.
View Storybook
View Chromatic build

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (5ce862e) to head (47a5acb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files         171      171           
  Lines        5778     5778           
  Branches      663      663           
=======================================
  Hits         4528     4528           
  Misses       1098     1098           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominik003 dominik003 force-pushed the chore-migrate-to-angular-standalone-components branch 2 times, most recently from f5e877d to 13b258c Compare April 29, 2024 14:45
@MoritzWeber0 MoritzWeber0 force-pushed the chore-migrate-to-angular-standalone-components branch from 13b258c to 370dc6c Compare April 30, 2024 07:23
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token overview didn't load anymore, had to add MatNativeDateModule to the main.ts. Beside that, things look fine after some manual testing. Thanks for the change :)

This migratee the frontend components to standalone components.
This is required for Storybook to use components, but also removes
the need for the `@NgModule` inside the app modules file. The changes
here were mostly done automatically using the
[migration CLI](https://angular.io/guide/standalone-migration).
@MoritzWeber0 MoritzWeber0 force-pushed the chore-migrate-to-angular-standalone-components branch from 370dc6c to 47a5acb Compare April 30, 2024 07:28
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 25efb64 into main Apr 30, 2024
27 of 29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the chore-migrate-to-angular-standalone-components branch April 30, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants