fix: Termination of sessions #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automatic termination of idle sessions stopped working with #1573. Reason is that the app label was removed from Prometheus. This commit migrates the old app references to the new session_id label.
|
A Storybook preview is available for commit 7b39b82. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 185 185
Lines 5970 5970
Branches 666 666
=======================================
Hits 4765 4765
Misses 1061 1061
Partials 144 144 ☔ View full report in Codecov by Sentry. |
|
Tested in the staging environment, works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic termination of idle sessions stopped working with #1573. Reason is that the app label was removed from Prometheus.
This commit migrates the old app references to the new session_id label.