Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused certificate generation for OAuth mock #1604

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

MoritzWeber0
Copy link
Member

We don't use the certificate generation, so we can remove it.

We don't use the certificate generation, so we can remove it.
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

github-actions bot commented Jun 4, 2024

A Storybook preview is available for commit 9ce88a6.
View Storybook
View Chromatic build

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (6e6e779) to head (c764ef3).
Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1604   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files         185      185           
  Lines        5970     5970           
  Branches      666      666           
=======================================
  Hits         4765     4765           
  Misses       1061     1061           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jamilraichouni jamilraichouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same change locally and it works.

@MoritzWeber0 MoritzWeber0 merged commit 8673dc0 into main Jun 5, 2024
40 checks passed
@MoritzWeber0 MoritzWeber0 deleted the remove-local-oauth-ssl-support branch June 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants