Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce Storybook log level and fix warnings #1607

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

MoritzWeber0
Copy link
Member

Storybook did spam the terminal with messages, which is especially annoying when running make dev.

This PR reduces the log level by adding the --quite flag.

In addition, there were some valid WARN messages about wrong usage of the files attribute in the tsconfig.json. Those warnings are resolved.

Storybook did spam the terminal with messages, which is especially
annoying when running `make dev`.

This PR reduces the log level by adding the --quite flag.

In addition, there were some valid WARN messages about wrong usage
of the files attribute in the `tsconfig.json`. Those warnings are resolved.
Copy link

github-actions bot commented Jun 5, 2024

A Storybook preview is available for commit 757cee2.
View Storybook
View Chromatic build

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 requested review from jamilraichouni and removed request for jamilraichouni June 5, 2024 10:03
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (561e5f4) to head (86ee007).
Report is 125 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files         185      185           
  Lines        5970     5970           
  Branches      666      666           
=======================================
  Hits         4765     4765           
  Misses       1061     1061           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit bfa900d into main Jun 5, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the reduce-storybook-logging branch June 5, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant