fix(monitoring): Filter out negative values #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative values indicate failured in the metrics collection. They produce unclear jumps in the time series and influence the min and mean values. In addition, the color of the mean value was wrong. This is fixed.
|
A Storybook preview is available for commit adc359c. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 185 185
Lines 5970 5970
Branches 666 666
=======================================
Hits 4765 4765
Misses 1061 1061
Partials 144 144 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative values indicate failures in the metrics collection. They produce unclear jumps in the time series and influence the min and mean values.
Before:
After:
In addition, the color of the mean value was wrong. This is fixed.