fix: Tolerate Pods without labels in metrics #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Pods may not have labels, for example the Pods created by our CLI during the restore process. The deployed sessions collector should not fail when it hits such a Pod. Instead, it should just ignore it.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
+ Coverage 80.64% 80.65% +0.01%
==========================================
Files 185 185
Lines 6090 6095 +5
Branches 678 679 +1
==========================================
+ Hits 4911 4916 +5
Misses 1030 1030
Partials 149 149 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Pods may not have labels, for example the Pods created by our CLI during the restore process.
The deployed sessions collector should not fail when it hits such a Pod. Instead, it should just ignore it.