Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused audience configuration field #1686

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dominik003
Copy link
Contributor

@dominik003 dominik003 commented Aug 5, 2024

This removes the unused audience configuration field. The field is not used because authentication.client_id is the expected audience for the issued identity tokens, so we do not need a separate field for it.

Resolves #1685

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (72a2860) to head (ac0ec46).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   83.97%   83.97%   -0.01%     
==========================================
  Files         184      184              
  Lines        6086     6085       -1     
  Branches      673      673              
==========================================
- Hits         5111     5110       -1     
  Misses        827      827              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominik003 dominik003 changed the title refactor: Remove unused audience configuration refactor: Remove unused audience configuration field Aug 5, 2024
Copy link

sonarcloud bot commented Aug 5, 2024

@MoritzWeber0 MoritzWeber0 merged commit b46dc01 into main Aug 12, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the refactor-remove-unused-audience-configuration branch August 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused audience configuration field
2 participants