Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken loading animation of model sources #1776

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

MoritzWeber0
Copy link
Member

The model sources view which lists Git and T4C repositories had a broken loading animation. Also, some UI elements were refreshed.

A new star indicates a primary Git repository (instead of text).

Copy link

github-actions bot commented Sep 10, 2024

A Storybook preview is available for commit 0b5c8a0.
➡️ View Storybook
➡️ View Chromatic build
🔍 3 out of 32 snapshots have changed. Please review the changes before merging.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (83cf867) to head (4009f36).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         186      186           
  Lines        6138     6138           
  Branches      675      675           
=======================================
  Hits         5159     5159           
  Misses        831      831           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The model sources view which lists Git and T4C repositories had a broken
loading animation. Also, some UI elements were refreshed.

A new star indicates a primary Git repository (instead of text).
Copy link

sonarcloud bot commented Sep 10, 2024

@MoritzWeber0 MoritzWeber0 merged commit 97bffb2 into main Sep 10, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-loading-modelsources branch September 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant