fix: Remove WWW-Authenticate header from responses
#1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP specification recommends to send a `WWW-Authenticate` header with status code 401. We've used that to indicate which authentication methods are available for clients, in our case Basic and Cookie. While this works fine on Chrome, Safari starts prompting for basic authentication on its own. I haven't found a way to suppress, so we'll have to remove the `WWW-Authenticate` header to avoid this behaviour.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 186 186
Lines 6144 6144
Branches 676 676
=======================================
Hits 5165 5165
Misses 831 831
Partials 148 148 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP specification recommends to send a
WWW-Authenticateheader with status code 401 for unauthenticated cases. See also the Mozilla documentation page: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/401.We've used that to indicate which authentication methods are available for clients, in our case Basic and Cookie.
While this works fine for Chrome, Safari starts prompting for basic authentication on its own. I haven't found a way to suppress this, so we'll have to remove the
WWW-Authenticateheader to avoid this behaviour.Resolves #1788