Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fail helm upgrade if secrets are not set in values.yaml #1818

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

MoritzWeber0
Copy link
Member

To avoid unintential default secrets in production, passwords default to null now. helm upgrade will fail if the secrets are not set.

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the refactor-git-handler branch 3 times, most recently from 3d67ea4 to 9bc25bd Compare September 20, 2024 21:20
Base automatically changed from refactor-git-handler to main September 20, 2024 21:32
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (6828e3a) to head (4e8a758).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
backend/capellacollab/core/logging/loki.py 12.50% 7 Missing ⚠️
backend/capellacollab/config/models.py 77.77% 1 Missing and 1 partial ⚠️
backend/capellacollab/sessions/operators/k8s.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
- Coverage   84.13%   84.04%   -0.09%     
==========================================
  Files         194      194              
  Lines        6441     6468      +27     
  Branches      708      715       +7     
==========================================
+ Hits         5419     5436      +17     
- Misses        867      876       +9     
- Partials      155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

To avoid unintential default secrets in production, passwords default to null now.
`helm upgrade` will fail if the secrets are not set.
Copy link

sonarcloud bot commented Sep 23, 2024

Copy link

This report was generated by comparing 9efebeb with 6828e3a.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 262
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 9818b04 into main Sep 23, 2024
30 of 31 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fail-if-secrets-unset branch September 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant