feat: Make nginx error pages more user-friendly #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzWeber0
force-pushed
the
modernize-nginx-error-pages
branch
from
9b5dd92
to
441b29f
Compare
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1850 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 195 195
Lines 6487 6487
Branches 720 720
=======================================
Hits 5473 5473
Misses 855 855
Partials 159 159 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
zusorio
reviewed
Sep 30, 2024
MoritzWeber0
force-pushed
the
modernize-nginx-error-pages
branch
2 times, most recently
from
920a087
to
b4d2e13
Compare
This comment has been minimized.
This comment has been minimized.
|
A Storybook preview is available for commit ac5f236. |
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
modernize-nginx-error-pages
branch
from
b4d2e13
to
82c81a1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 401 error page:
The new 502 error page:
This also fixes a bug that an "500 - Internal server error" page was displayed when the user tried to access a session without session token.