feat: Add better edge case handling in session overview #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 197 197
Lines 6549 6549
Branches 729 729
=======================================
Hits 5530 5530
Misses 859 859
Partials 160 160 ☔ View full report in Codecov by Sentry. |
|
A Storybook preview is available for commit b2d8b11. |
This comment has been minimized.
This comment has been minimized.
The loading and "no sessions" cases are now handled separately.
MoritzWeber0
force-pushed
the
loading-screen-session-overview
branch
from
90f4143
to
e0c2998
Compare
|
|
This report was generated by comparing b2d8b11 with 43fa869. ArtifactName:
|
| item | count |
|---|---|
| pass | 302 |
| change | 0 |
| new | 8 |
| delete | 0 |
📝 Report
New Items
Session Components_Session Overview_All Selected_desktop.png
 |
Session Components_Session Overview_All Selected_mobile.png
 |
Session Components_Session Overview_Loading_desktop.png
 |
Session Components_Session Overview_Loading_mobile.png
 |
Session Components_Session Overview_No Sessions_desktop.png
 |
Session Components_Session Overview_No Sessions_mobile.png
 |
Session Components_Session Overview_Overview_desktop.png
 |
Session Components_Session Overview_Overview_mobile.png
 |
MoritzWeber0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading and "no sessions" cases are now handled separately.