fix: Fix the previous OPEN_TIMEOUT fix not being properly applied #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zusorio
force-pushed
the
increase-open-timeout-fixed
branch
from
bc691ec to
087a737
Compare
MoritzWeber0
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Ok as temporary workaround until Xpra-org/xpra-html5@af1b036 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix unfortunately was not properly applied because OPEN_TIMEOUT was being read before being overwritten. By setting it before it's being read, the previous issues are fully fixed.
Closes #350