Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates improvements #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Templates improvements #13

wants to merge 3 commits into from

Conversation

MFK-18
Copy link
Collaborator

@MFK-18 MFK-18 commented Jun 7, 2024

feat:Update of the system definition acc. to what was in Conflunence for DBS Ref. Edited the macros just to fit the filters for diagrams.

Copy link

github-actions bot commented Jun 7, 2024

The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/.
We also strongly recommend that you set up your development environment with pre-commit, as described in our CONTRIBUTING guidelines. This will run all the important checks right before you commit your changes, and avoids lengthy CI wait time and round trips.

This is the commit validation log:

⧗   input: FEAT: Improved system definition template acc. to DBS ref standard and edited common_macros for diagram filter option and no-content text editing
✖   subject must not be longer than 72 characters [subject-max-length]
✖   type must be one of [build, chore, ci, docs, feat, fix, merge, perf, refactor, revert, test] [type-enum]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: FEAT: Updated system functions template with functional exchanges(according to viktors comment)
✖   subject must not be longer than 72 characters [subject-max-length]
✖   type must be one of [build, chore, ci, docs, feat, fix, merge, perf, refactor, revert, test] [type-enum]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: commit message
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Here are some examples of valid commit messages:

build: Bump dependency versions
docs(user): Add model creation workflow
feat: Add a monitoring dashboard

@MFK-18 MFK-18 marked this pull request as ready for review June 7, 2024 09:07
@MFK-18 MFK-18 requested a review from vik378 June 7, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant