Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags are cropped in Card view #62

Closed
lucastucious opened this issue Oct 30, 2023 · 1 comment
Closed

Tags are cropped in Card view #62

lucastucious opened this issue Oct 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lucastucious
Copy link

image

System info (please complete the following information):

  • OS: Windows 10
  • Release Version1.5.1
@lucastucious lucastucious added the bug Something isn't working label Oct 30, 2023
@github-project-automation github-project-automation bot moved this to Needs review in COMPASS Roadmap Oct 30, 2023
@DSPaul
Copy link
Owner

DSPaul commented Oct 30, 2023

This is unfortunately a known issue, it has to do with a library that I use that massively improves render times, but cannot deal with dynamic sizing, this is the related issue from that library: sbaeumlisberger/VirtualizingWrapPanel#22
The author is working on a v2 of the library which adds support for this and I have already confirmed fixes this problem but it introduces other bugs in its place so it's not ready yet.

To determine the size of all the cards, the library will look at the size required to render the first one, and makes all the others the same size. And because the first item in your list doesn't have any tags, no space is reserved for them and all of them will have too little space to render them. You will see that giving the first one a tag will fix it ... until you have a book with multiple lines of tags and the problem comes back as you can see here.
afbeelding

What I will do is make sure there is always space reserved for at least 1 line of tags as that should cover most use cases, as for multi line, it's waiting on that v2 update.

@DSPaul DSPaul moved this from Needs review to In Progress in COMPASS Roadmap Oct 30, 2023
@DSPaul DSPaul moved this from In Progress to Planned Short Term in COMPASS Roadmap Nov 6, 2023
@DSPaul DSPaul moved this from Planned Short Term to In Progress in COMPASS Roadmap Jan 10, 2024
@DSPaul DSPaul moved this from In Progress to Done in COMPASS Roadmap Jan 27, 2024
@DSPaul DSPaul closed this as completed in 283e57c Mar 10, 2024
@github-project-automation github-project-automation bot moved this from Done to Released in COMPASS Roadmap Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
Development

No branches or pull requests

2 participants