feat: add initial options validation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related discussion around required/optional members of the |
|
This ready to go? You’ve sold me already haha |
|
@DSchau I need to update the required fields to meet the discussions I've been having in w3c/manifest#799 and I haven't written/added tests or documentation for this. If you would like to do any of this go for it. I'm at work and need to get back to it. |
…n options validation
…c they adhear to.
moonmeister
force-pushed
the
feat/manifest-option-validation
branch
from
66ca3ae to
1e7a0e3
Compare
|
@DSchau tested, fixed and documented. All ready to go for you! |
DSchau
pushed a commit
that referenced
this pull request
Apr 16, 2020
* initial RFC Signed-off-by: Alex Moon <alex.jared.moon@gmail.com> * add API suggestion, add config cmd, add config key question, remove enable/disable * add prompt around changes and officia readmes needing updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic plugin validation for
gatsby-plugin-manifest.Still need to look into further:
seeing if we can throw a info log if a config is explicitly set to it's implicit default.@DSchau Any other changes you suggest or things i could do to improve this?
Related Issues
gatsbyjs#16027