Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated decorator @asyncio.coroutine #24

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

thulin82
Copy link
Contributor

@thulin82 thulin82 commented Jun 7, 2023

https://docs.python.org/3.10/library/asyncio-task.html#generator-based-coroutines

Support for generator-based coroutines is deprecated and is removed in Python 3.11.

Fixes #23 (i hope)

Could use some more testing

Copy link

@angarok angarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for me. Nice work!

Copy link

@fnordpojk fnordpojk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the problem for me.

@linux169
Copy link

linux169 commented Jun 9, 2023

It fixed the problem for me aswell but took awhile to start and got this error in the logs don't know if it's related

fetch data failed : HTTPSConnectionPool(host='postnummersok.citymail.se', port=443): Max retries exceeded with url: /?search="censored" (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f780a4568d0>, 'Connection to postnummersok.citymail.se timed out. (connect timeout=None)'))

Copy link

@ticstyle ticstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the issue and I get no errors in the logs.

Update:
Works fine in 2023.06.1 too 👍

Copy link

@mikaabra mikaabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested, makes this work on 2023.6.1 again.

@DSorlov DSorlov merged commit ef5d0fa into DSorlov:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Assistant 2023.6.0 upgrades Python to 3.11. Breaks loading.
7 participants