Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose scripts to resync with DSpace/DSpace #1090

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Apr 7, 2021

The Docker Compose scripts in DSpace/dspace-angular have become slightly out of sync with those in DSpace/DSpace.

This PR syncs them back up, namely by updating the following:

  1. Porting Update links to Entities test data DSpace#3225 to dspace-angular
  2. Updating dspace-angular compose scripts to use Solr 8.x, as we forgot to modify the scripts in this repository after Upgrade to latest Guava (v30) and Solr (v8) to resolve security alerts DSpace#3020 was merged.

The best test for these changes is the GitHub CI. I'll also run manual testing via Docker to verify it's working properly & report back in the comments.

@tdonohue tdonohue added configuration 1 APPROVAL pull request only requires a single approval to merge labels Apr 7, 2021
@tdonohue tdonohue added this to the 7.0beta5 milestone Apr 7, 2021
@tdonohue tdonohue self-assigned this Apr 7, 2021
@tdonohue tdonohue added the backend: Docker related to DSpace deployment via Docker label Apr 9, 2021
@tdonohue tdonohue force-pushed the update_docker branch 2 times, most recently from 8c7f161 to 2053172 Compare April 14, 2021 19:36
…from 'dspace' container as they aren't in the dspace-angular codebase
@tdonohue
Copy link
Member Author

I've fully tested these updates using the instructions at https://wiki.lyrasis.org/display/DSPACE/Try+out+DSpace+7#TryoutDSpace7-InstallviaDocker (as those instructions reference dspace-angular's Docker scripts). All instructions now work (one last bug fix was pushed up).

Once GitHub CI approves, this will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant