Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR hides the
Entity Type
field in both the create and edit collection form when the entities are not initialised yet. It also fixes a small bug in the collection, community, eperson & group form where hittingENTER
in a field would lead to other buttons from being triggered like cancel or go back which causes the form to close.Instructions for Reviewers
List of changes in this PR:
CollectionFormComponent
: hide theEntity Type
field when there are no entity typesComColFormComponent
,GroupFormComponent
,EPersonFormComponent
: some buttons in the<form>
s did not have the correct type which lead to incorrect actions being called whenGuidance for how to test and review this PR:
initialize-entities -f ../dspace/config/entities/relationship-types.xml
and check that that field is now visible in both formsDSpaceObject
is correctly createdChecklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.