Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-710][redis] Fix writing to redis in sql mode reports illegal argument exception #715

Merged
merged 1 commit into from
Apr 15, 2022
Merged

[hotfix-710][redis] Fix writing to redis in sql mode reports illegal argument exception #715

merged 1 commit into from
Apr 15, 2022

Conversation

libailin
Copy link
Contributor

@libailin libailin mentioned this pull request Apr 14, 2022
Closed
Zhu4680
Zhu4680 reviewed Apr 14, 2022
View reviewed changes
docs/connectors/redis/redis-sink.md
- 必选：是
- 默认值：无
<br />

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个参数能否拆开，分成两个独立的参数呢？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前json模式文档就是在一起的，type 和 mode 是配套使用的，拆开的话估计不利于用户理解使用

Zhu4680
Zhu4680 reviewed Apr 14, 2022
View reviewed changes
docs/connectors-en/redis/redis-sink.md
- Required：yes
- Default：(none)
<br />

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否将这两个参数分开，拆成两个独立的参数说明呢？

@FlechazoW FlechazoW merged commit 38de1f7 into DTStack:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhu4680 Zhu4680 Zhu4680 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@libailin @Zhu4680 @FlechazoW