fix: delcare the useEffect before return (#808)

DTStack · Sep 29, 2022 · 3b73285 · 3b73285
1 parent 219b937
commit 3b73285
Showing 1 changed file with 19 additions and 19 deletions.
diff --git a/src/workbench/sidebar/explore/folderTree.tsx b/src/workbench/sidebar/explore/folderTree.tsx
@@ -90,25 +90,6 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
         current,
     } = folderTree;
 
-    const handleAddRootFolder = () => {
-        createTreeNode?.('RootFolder');
-    };
-
-    const welcomePage = (
-        <div data-content={panel.id}>
-            {entry ? (
-                <>{entry}</>
-            ) : (
-                <div style={{ padding: '10px 5px' }}>
-                    you have not yet opened a folder
-                    <Button onClick={handleAddRootFolder}>Add Folder</Button>
-                </div>
-            )}
-        </div>
-    );
-
-    if (!data.length) return welcomePage;
-
     const inputRef = useRef<HTMLInputElement>(null);
     // tree context view
     const contextMenu = useRef<ReturnType<typeof useContextMenu>>();
@@ -221,6 +202,10 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
         onDropTree?.(source, target);
     };
 
+    const handleAddRootFolder = () => {
+        createTreeNode?.('RootFolder');
+    };
+
     useEffect(() => {
         if (folderPanelContextMenu.length > 0) {
             contextMenu.current = initContextMenu();
@@ -230,6 +215,21 @@ const FolderTree: React.FunctionComponent<IFolderTreeProps> = (props) => {
         };
     }, [data.length]);
 
+    const welcomePage = (
+        <div data-content={panel.id}>
+            {entry ? (
+                <>{entry}</>
+            ) : (
+                <div style={{ padding: '10px 5px' }}>
+                    you have not yet opened a folder
+                    <Button onClick={handleAddRootFolder}>Add Folder</Button>
+                </div>
+            )}
+        </div>
+    );
+
+    if (!data.length) return welcomePage;
+
     return (
         <Scrollable noScrollX isShowShadow>
             <div data-content={panel.id} style={{ height: '100%' }}>