Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate command palette in editor context menu #243

Merged
merged 1 commit into from
Jul 14, 2021
Merged

fix: duplicate command palette in editor context menu #243

merged 1 commit into from
Jul 14, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 editor 的右键菜单存在重复的命令面板

主要变更

  • editor 的右键菜单自带了一个 Command Palette，只是没有快捷键绑定
  • So，添加快捷键绑定的时候不需要在 menu 上添加了，并且优化了 action 的 id，和 monaco 内置的保持一致，否则找不到 id 就显示不了快捷键了

Related Issues

closed #241

@mortalYoung mortalYoung requested a review from wewoor July 14, 2021 10:19
@wewoor wewoor merged commit 111a4cd into main Jul 14, 2021
@wewoor wewoor deleted the fix/command branch July 14, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wewoor wewoor Awaiting requested review from wewoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate the CommandPalette menu item
2 participants
@mortalYoung @wewoor