Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update foldertree new folder #247

Merged
merged 1 commit into from
Jul 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/components/tree/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,31 @@ const TreeView = ({
onRightClick?.(info);
};

React.useLayoutEffect(() => {
const cache: { path: string; data: ITreeNodeItemProps }[] = [];
data.forEach((item) => {
cache.push({ path: `${item.id}`, data: item });
});

while (cache.length) {
const { path, data } = cache.pop()!;
const editableChild = data.children?.find(
(child) => child.isEditable
);
if (editableChild) {
treeRef.current?.setExpandedKeys(path.split('-'));
break;
} else {
const children =
data.children?.map((child) => ({
path: `${path}-${child.id}`,
data: child,
})) || [];
cache.push(...children);
}
}
}, [data]);

return (
<div className={classNames(prefixClaName('tree'), className)}>
<div className={prefixClaName('tree', 'sidebar')}>
Expand Down
20 changes: 19 additions & 1 deletion src/extensions/folderTree/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const ExtendsFolderTree: IExtension = {
id: `${file.id}`?.split('_')?.[0],
modified: false,
data: {
...(file.data || {}),
value: file.content,
path: file.location,
language: extName,
Expand Down Expand Up @@ -92,12 +93,29 @@ export const ExtendsFolderTree: IExtension = {
isEditable: false,
});
} else {
tree.remove(id);
// TODO: improve tree helper types
const node = (tree.get(id) as unknown) as ITreeNodeItemProps;
if (node.name) {
tree.update(id, {
isEditable: false,
});
} else {
tree.remove(id);
}
}

if (index > -1) cloneData[index] = tree.obj;
molecule.folderTree.setState({
folderTree: { ...folderTree, data: cloneData },
});

const isOpened = molecule.editor.isOpened(id.toString());
if (isOpened) {
molecule.editor.updateTab({
id: id.toString(),
name,
});
}
if (file?.fileType === FileTypes.File && file.name) {
// emit onSelectFile
}
Expand Down
7 changes: 7 additions & 0 deletions src/model/workbench/explorer/folderTree.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,15 @@ export class TreeNodeModel implements ITreeNodeItemProps {
id?: number;
name?: string;
location?: string;
isLeaf?: boolean;
fileType?: FileType;
children?: ITreeNodeItemProps[];
icon?: string | React.ReactNode;
isEditable?: boolean;
content?: string;

data?: any;

constructor(props: ITreeNodeItemProps = {}) {
const {
id,
Expand All @@ -118,6 +121,8 @@ export class TreeNodeModel implements ITreeNodeItemProps {
icon = '',
isEditable = false,
content = '',
isLeaf = true,
data,
} = props;
this.fileType = fileType;
this.isEditable = isEditable;
Expand All @@ -127,6 +132,8 @@ export class TreeNodeModel implements ITreeNodeItemProps {
this.children = children;
this.icon = icon;
this.content = content;
this.data = data;
this.isLeaf = isLeaf;
}
}

Expand Down
62 changes: 49 additions & 13 deletions src/services/workbench/editorService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,19 @@ export interface IEditorService extends Component<IEditor> {
tabId: string,
group: IEditorGroup
): IEditorTab<T> | undefined;
updateTab(tab: IEditorTab, groupId: number): IEditorTab;
/**
*
* @param groupId If not provided, molecule will update in all group
*/
updateTab(tab: IEditorTab, groupId?: number): IEditorTab;
/**
* Specify a entry page for editor
*/
setEntry(component: React.ReactNode): void;
/**
* Returns whether a specific tab exists
*/
isOpened(tabId: string): boolean;
closeTab(tabId: string, groupId: number): void;
closeOthers(tab: IEditorTab, groupId: number): void;
closeToRight(tab: IEditorTab, groupId: number): void;
Expand Down Expand Up @@ -91,6 +99,11 @@ export class EditorService
});
}

public isOpened(tabId: string): boolean {
const { groups = [] } = this.state;
return groups.some((group) => this.getTabById(tabId, group));
}

public updateGroupActions(actions: IMenuItemProps[]): void {
this.groupActions = actions;
}
Expand All @@ -112,24 +125,47 @@ export class EditorService
return this.state.current?.editorInstance;
}

public updateTab(tab: IEditorTab, groupId: number): IEditorTab {
const { groups = [] } = this.state;
const index = this.getGroupIndexById(groupId);
public updateTab(tab: IEditorTab, groupId?: number): IEditorTab {
if (groupId) {
const group = this.getGroupById(groupId);

if (index > -1) {
const group = groups[index];
if (group?.data?.length) {
const tabData = group.data.find(searchById(tab.id));

if (group.data && group.data.length > 0) {
const tabIndex = group.data!.findIndex(searchById(tab.id));
if (tabData) {
Object.assign(tabData, tab);
}

if (tabIndex > -1) {
const tabData = group.data![tabIndex];
const newTab = Object.assign({}, tabData, tab);
group.data![tabIndex] = newTab;
if (group.activeTab === tab.id) {
Object.assign(group.tab, tab);
}
this.updateGroup(groupId, group);

this.render();
if (groupId === this.state.current?.id) {
this.updateCurrentGroup(group);
}
}
} else {
const { groups = [], current } = this.state;
groups.forEach((group) => {
const tabData = this.getTabById(tab.id!, group);
if (tabData) {
Object.assign(tabData, tab);
}

if (group.activeTab === tab.id) {
Object.assign(group.tab, tab);
}
});

if (current?.activeTab === tab.id) {
Object.assign(current!.tab, tab);
}

this.setState({
current,
groups,
});
}
return tab;
}
Expand Down
6 changes: 5 additions & 1 deletion src/services/workbench/explorer/folderTreeService.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'reflect-metadata';
import { singleton, container } from 'tsyringe';
import cloneDeep from 'lodash/cloneDeep';
import { Component } from 'mo/react/component';
import {
FileTypes,
Expand Down Expand Up @@ -91,7 +92,10 @@ export class FolderTreeService
}
cloneData[index] = tree.obj;
this.setState({
folderTree: { ...this.state.folderTree, data: cloneData },
folderTree: {
...this.state.folderTree,
data: cloneDeep(cloneData),
},
});
} else {
console.warn('Please check id again, there is not folder tree');
Expand Down
1 change: 1 addition & 0 deletions stories/extensions/test/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export const ExtendTestPane: IExtension = {
id: randomId(),
name: '',
fileType: FileTypes.Folder,
isLeaf: false,
isEditable: true,
})
);
Expand Down