feat(menubar): add menu bar methods to service and support shortcut keys #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumiao
reviewed
Jul 30, 2021
wewoor
reviewed
Jul 30, 2021
ProfBramble
changed the title
mumiao
reviewed
Aug 4, 2021
| } from 'mo/model'; | ||
| import { FolderTreeService, IFolderTreeService } from 'mo/services'; | ||
| import { randomId } from 'mo/common/utils'; | ||
|
|
||
| const confirm = Modal.confirm; | ||
| export interface IFolderTreeController { | ||
| readonly createFileOrFolder?: (type: keyof typeof FileTypes) => void; | ||
| readonly createFileOrFolder?: (type: FileType) => void; |
There was a problem hiding this comment.
rebase一下main分支，这个API被refactor了
|
conflicts @ProfBramble |
|
rebase一下 抵消一些变更 ，还是conflicts |
ProfBramble
force-pushed
the
feat/menuBar
branch
2 times, most recently
from
6b63d27
to
1e12932
Compare
* refactor: remove addRootMenu method, and rename initMenu to initMenus * docs: add comments for the IMenuBarService interface
ProfBramble
force-pushed
the
feat/menuBar
branch
from
880e0de
to
1e653bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
主要变更
createFileOrFolder调度至 folderTreeServicecreateFileOrFolderquickCopyLineUpquickSelectAllRelated Issues
Closed #264