Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve tooltip in different color theme #304

Merged
merged 2 commits into from
Aug 3, 2021
Merged

fix: improve tooltip in different color theme #304

merged 2 commits into from
Aug 3, 2021

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Aug 3, 2021

简介

  • 优化 tooltip 的颜色主题

主要变更

  • 移除 tooltip 的自定义颜色,采用 menu 的颜色主题

Related issues

Closed #303
#259

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这里缺少一个针对 mac 操作系统字体设置的逻辑

@mortalYoung
Copy link
Collaborator Author

image

这里缺少一个针对 mac 操作系统字体设置的逻辑

done~

@mortalYoung mortalYoung added the bug Something isn't working label Aug 3, 2021
@wewoor wewoor merged commit 219c241 into main Aug 3, 2021
@wewoor wewoor deleted the fix/tooltip branch August 3, 2021 12:32
ProfBramble pushed a commit that referenced this pull request Aug 5, 2021
* fix: improve tooltip in different color theme

* fix(components): add font-family in mac for tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Tooltip component lost the ColorTheme and basic styles
2 participants