Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the searchById method #469

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: fix the searchById method #469

merged 1 commit into from
Oct 13, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 searchById 方法报错的问题

@mortalYoung mortalYoung added the bug Something isn't working label Oct 13, 2021
@mortalYoung mortalYoung self-assigned this Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #469 (a6db65d) into main (fbb4113) will increase coverage by 0.11%.
The diff coverage is 83.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   81.26%   81.38%   +0.11%     
==========================================
  Files         181      179       -2     
  Lines        5072     5092      +20     
  Branches     1112     1118       +6     
==========================================
+ Hits         4122     4144      +22     
+ Misses        941      939       -2     
  Partials        9        9              
Impacted Files Coverage Δ
src/common/event/eventEmitter.ts 100.00% <ø> (+29.16%) ⬆️
src/extensions/editorTree/index.ts 40.00% <0.00%> (-12.95%) ⬇️
src/extensions/folderTree/index.tsx 25.00% <0.00%> (-1.32%) ⬇️
src/extensions/index.ts 100.00% <ø> (ø)
src/extensions/keybinding/index.ts 92.85% <0.00%> (-7.15%) ⬇️
src/extensions/menuBar/index.ts 75.00% <0.00%> (-25.00%) ⬇️
src/extensions/panel/index.ts 40.00% <0.00%> (-2.86%) ⬇️
src/extensions/activityBar/index.ts 40.00% <33.33%> (-6.16%) ⬇️
src/extensions/explorer/index.ts 66.66% <50.00%> (-8.34%) ⬇️
src/common/event/eventBus.ts 100.00% <100.00%> (+28.57%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c66958...a6db65d. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 03e32fb into main Oct 13, 2021
@wewoor wewoor deleted the fix/extensionService branch October 13, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants