Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the timing of loading language extensions and improve built-in modules #478

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 优化语言拓展包加载的时机
  • 优化内置模块

主要变更

  • 优化内置模块的获取方式,通过 function 的形式延迟加载,从而保证内置模块中的 localize 方法执行的时候,已经存在正确的语言环境
  • 优化语言拓展包加载的时机,确保语言拓展包先加载且设置当前语言

遗留问题

  • 内置模块的类型问题

@mortalYoung mortalYoung self-assigned this Oct 21, 2021
@mortalYoung
Copy link
Collaborator Author

mortalYoung commented Oct 21, 2021

这个类型问题,实在不知道怎么解决了,所以给了 any,有什么好办法可以解决吗 cc @wewoor

Copy link
Contributor

@ProfBramble ProfBramble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

any 的问题我合到我这的分支后看看

@ProfBramble ProfBramble merged commit f0bfabb into feat/extendsLocales Oct 22, 2021
@ProfBramble ProfBramble deleted the fix/builtin branch October 22, 2021 03:11
ProfBramble pushed a commit that referenced this pull request Oct 26, 2021
…lt-in modules (#478)

* fix: adjust the timing of loading language extensions and improve built-in modules

* test: update the built-in modules in tests
wewoor pushed a commit that referenced this pull request Oct 27, 2021
* feat: add locals default extensions

* feat: add localeService adaptation and judgment

* feat: cancel the internationalization interface in the provider

* feat: add extension service adaptation for internationalization functionality

* feat: specify language packages using package

* feat: code to beautify

* feat: add an international extension interface

* feat: provider supports custom locale

* feat: remove the locals package configuration file

* feat: removes the settings on package from extends

* fix: correct spelling mistakes

* feat: remove unnecessary interfaces

* feat: redefine locales interface

* test: snapshot processing for locales

* feat: extract internationalization constants that are started by default

* test: switch matching error in internationalization execution

* perf: sorting out useless methods

* fix: setting service effect does not change during internationalization modification

* feat: add custom extension languages

* feat: provide initialization at provider

* feat: add locales-plus extensions

* feat: adds method called by the language package

* feat: added english internationalization extension

* fix: verify that the local service language is abnormal

* feat: add localels setting operation

* fix: adjust the timing of loading language extensions and improve built-in modules (#478)

* fix: adjust the timing of loading language extensions and improve built-in modules

* test: update the built-in modules in tests

* test: support builtin function single test

* fix: maintain single test defaults

Co-authored-by: 野迂迂 <yangwei1@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants