Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-layout the Workbench when StatusBar is hidden #557

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

kiwiwong
Copy link
Collaborator

Description

  • 修复当 StatusBar 隐藏时的布局问题
  • 修复 ActivityBar 的右键菜单中 Menu 项的勾选状态问题

Changes

  • 当隐藏 StatusBar 时更新布局样式
  • 点击 MenuBar 中的 Show Menu Bar 时,增加对 ActivityBar 右键菜单状态的更新

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #557 (db552a2) into main (2cf2abb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   86.74%   86.77%   +0.02%     
==========================================
  Files         189      189              
  Lines        5562     5571       +9     
  Branches     1243     1245       +2     
==========================================
+ Hits         4825     4834       +9     
  Misses        727      727              
  Partials       10       10              
Impacted Files Coverage Δ
src/controller/menuBar.ts 100.00% <100.00%> (ø)
src/workbench/workbench.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf2abb...db552a2. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor changed the title fix: fix the layout when StatusBar is hidden fix: re layout the Workbench when StatusBar is hidden Dec 21, 2021
@wewoor wewoor changed the title fix: re layout the Workbench when StatusBar is hidden fix: re-layout the Workbench when StatusBar is hidden Dec 21, 2021
@wewoor wewoor added the bug Something isn't working label Dec 21, 2021
@wewoor wewoor added this to the 0.9.0-beta.2 milestone Dec 21, 2021
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 2d89f56 into main Dec 21, 2021
@wewoor wewoor deleted the fix/statusBar branch December 21, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants