Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customized MenuBar data will be lost when modifying the MenuBar's mode #650

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Feb 11, 2022

Description

Fix the issue that the custom menu data is lost when the mode of MenuBar is modified.

Changes

  • Modified the logic of updating MenuBar data when modifying the MenuBar mode

@kiwiwong kiwiwong added the bug Something isn't working label Feb 11, 2022
@kiwiwong kiwiwong self-assigned this Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #650 (b04c576) into main (4b7d8de) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   89.33%   89.38%   +0.04%     
==========================================
  Files         185      185              
  Lines        5609     5631      +22     
  Branches     1327     1336       +9     
==========================================
+ Hits         5011     5033      +22     
  Misses        590      590              
  Partials        8        8              
Impacted Files Coverage Δ
src/model/workbench/menuBar.ts 100.00% <ø> (ø)
src/services/builtinService/const.ts 100.00% <ø> (ø)
src/controller/menuBar.ts 100.00% <100.00%> (ø)
src/controller/panel.tsx 100.00% <0.00%> (ø)
src/components/tabs/tab.tsx 100.00% <0.00%> (ø)
src/workbench/menuBar/horizontalView.tsx 100.00% <0.00%> (ø)
src/services/workbench/editorService.ts 98.12% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7d8de...b04c576. Read the comment docs.

@kiwiwong kiwiwong changed the title fix: custom MenuBar data is lost when modifying the MenuBar's mode fix: customized MenuBar data will be lost when modifying the MenuBar's mode Feb 11, 2022
src/controller/menuBar.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 15e219b into main Feb 16, 2022
@wewoor wewoor deleted the feat/menuBarMode branch February 16, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants