Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn web failed in windows #719

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix: yarn web failed in windows #719

merged 1 commit into from
Apr 6, 2022

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Apr 6, 2022

简介

  • 修复 windows 下运行 web 命令失败的问题

主要变更

  • 原因是因为执行 build:esm 后,在 windows 下路径分割符是 \, 'mo/common/xxx' 路径会转化成 '......\common/xxx' 这种路径,而 '' 是转译的,导致出现问题

Actually:

windows 下的 esm/workbench/editor/welcome/index.js 文件内容中部分如下:
image

Expected:

import { prefixClaName } from './../../../common/className';

Related Issues

Closed #718

@mortalYoung mortalYoung self-assigned this Apr 6, 2022
@mortalYoung mortalYoung added the bug Something isn't working label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #719 (94f5566) into main (4c809eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         189      189           
  Lines        5947     5947           
  Branches     1426     1426           
=======================================
  Hits         5432     5432           
  Misses        508      508           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c809eb...94f5566. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 05ad264 into main Apr 6, 2022
@wewoor wewoor deleted the fix/web branch April 6, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn web error
2 participants