Toggle off certain features & fix various bugs

[FahZohh]

Please make sure your pull request complies with these guidelines:

• • Use same formatting
• • Changes must have been tested on PMMP.
• • Unless it is a minor code modification, you must use an IDE.
• • Have a detailed title.

What does the PR change?

• Fixed /f top with large negative/positive numbers crashing server. (Toggle off certain features & fix various bugs #128)
• Fixed /f claim with large radiuses for circle/square toggles crashing server. (Toggle off certain features & fix various bugs #128)
• Fixed /f promote on an offline user crashing server. (Toggle off certain features & fix various bugs #128)
• NEW: Added ability to disable any commands. (Toggle off certain features & fix various bugs #128)
• NEW: Added ability to disable autoclaim, unclaimall, square, and circle claims. (Toggle off certain features & fix various bugs #128)
• NEW: Added ability to configure max radiuses for circle/square claims. (Toggle off certain features & fix various bugs #128)

Testing Environment

• PHP:
• PMMP:
• OS:

[Aericio]

• Why did you remove all the subcommands for /f claim and /f unclaim?
• Why did you remove /f enemy?
• You should be loading the virions using devirion plugin, NOT adding the libs directly.

[FahZohh]

• Why did you remove all the subcommands for /f claim and /f unclaim?
• Why did you remove /f enemy?
• You should be loading the virions using devirion plugin, NOT adding the libs directly.

when we do the /f claim circle 999999999999999999999999999999999 or other it crashes the server, I removed the f enemy but I think I'm going to put it back and offer people to activate or deactivate it.

[Thunder33345]

we cant even cherry pick the good stuff out because it's all in one single commit

[FahZohh]

we cant even cherry pick the good stuff out because it's all in one single commit

What do you want to take? You want me to do multiple commits? One for subcommands and the others

[FahZohh]

I did everything as you advised me if you have any suggestions or advice I will listen to them

[Aericio]

I will review this next month.

[FahZohh]

I put everything you advise, thank you very much

[Aericio]

We should just add command blacklisting instead, probably.

[FahZohh]

Having set limit for the /f top "PHP_INT_MAX" does not fix the main bug which is /f top power or member 999999999999999 and -999999999999999

[dadodasyra]

Why this PR deals with so many things..

By the way, limiting to PHP_INT_MAX will probably not suffice for commands that require complex calculations or database calls. As it could lead to hidden performance issues.

[FahZohh]

All commands that have an int can cause a crash, they should all be fixed at the same time

[Aericio]

@dadodasyra thanks for the feedback.

I'll most likely cherrypick the commits from this PR instead of merging.

About PHP_INT_MAX, should we just set the maximum to some reasonable limit instead then? like 100000.

@FahZohh Agreed. Maybe a helper function to validate numbers. Not sure what the best way to handle this is.

[FahZohh]

so we need to put a limit of 100000 for all commands that contain an int, but I have a question that won't do like last time or an extremely large number would probably result in an int overflow thus causing it to become a float ?

[Aericio]

Having set limit for the /f top "PHP_INT_MAX" does not fix the main bug which is /f top power or member 999999999999999 and -999999999999999

Oh, I see why this is still the case.

foreach (array_slice($factions, $page * self::PAGE_LENGTH, self::PAGE_LENGTH) as $rank => $faction)

Page being multiplied by 10 here, so it'll just turn back into a float here.

[Aericio]

This should be a better solution. We set the max as the number of possible factions, instead of PHP_INT_MAX.

[Aericio]

ok, seems to be working. don't feel like cherrypicking so weee