Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mac #107

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft

Support Mac #107

wants to merge 25 commits into from

Conversation

Neraste
Copy link
Member

@Neraste Neraste commented Apr 28, 2022

Fix #101.

Difficulties:

  • VLC:
    • install with brew install vlc --cask;
    • Correctly assign a window;
  • mpv:
    • Install with brew install mpv --cask;

Notes:

  • Tkinter crash when opening a window (see logs): it seems that the default build of Python for Mac cannot run Tk:
(.venv) user@host ~/D/d/dakara-feeder (feature/20_mac_support)> python -c "import tkinter; tkinter.Tk().mainloop()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/Cellar/python@3.10/3.10.4/Frameworks/Python.framework/Versions/3.10/lib/python3.10/tkinter/__init__.py", line 37, in <module>
    import _tkinter # If this fails your Python may not be configured for Tk
ModuleNotFoundError: No module named '_tkinter'

A solution was find using the example file of python-vlc.

Use dakara_base directory module.
Support Python 3.10.
Restrict to run only integration tests on Windows and Mac.
@Neraste Neraste added enhancement New feature or request release Anything related to releases or release process labels Apr 28, 2022
@Neraste Neraste self-assigned this Apr 28, 2022
@Neraste Neraste added this to the 1.8.0 milestone Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Attention: Patch coverage is 98.78049% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.22%. Comparing base (f8a2c45) to head (89c0884).
Report is 1 commits behind head on develop.

❗ Current head 89c0884 differs from pull request most recent head d9cc5b8. Consider uploading reports for the commit d9cc5b8 to get more accurate results

Files Patch % Lines
src/dakara_player/font.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
- Coverage    98.46%   98.22%   -0.24%     
===========================================
  Files           16       17       +1     
  Lines         1365     1411      +46     
===========================================
+ Hits          1344     1386      +42     
- Misses          21       25       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste Neraste changed the title Support Mac (and Python 3.10) Support Mac Nov 8, 2022
@Neraste Neraste modified the milestones: 1.8.0, 1.9.0 Nov 19, 2022
@Neraste
Copy link
Member Author

Neraste commented Mar 2, 2024

This PR is stalled and should be re-created from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release Anything related to releases or release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac support
1 participant