Merge pull request #874 from DalgoT4D/download-ui4t-parse-bug

fixed parsing of csv file while downloading

ddpui/api/warehouse_api.py

@@ -1,4 +1,6 @@
 import json
+import csv
+from io import StringIO
 import sqlparse
 from sqlparse.tokens import Keyword, Number, Token
 import uuid
@@ -254,10 +256,18 @@ def stream_warehouse_data(
             if not data:
                 break
             if not header_written:
-                yield ",".join(data[0].keys()) + "\n"  # Write CSV header
+                output = StringIO()
+                writer = csv.DictWriter(output, fieldnames=data[0].keys())
+                writer.writeheader()
+                yield output.getvalue()
                 header_written = True
+            output = StringIO()
+            writer = csv.DictWriter(output, fieldnames=data[0].keys())
             for row in data:
-                yield ",".join(map(str, row.values())) + "\n"  # Write CSV row
+                writer.writerow(row)
+                yield output.getvalue()
+                output.seek(0)
+                output.truncate(0)
             page += 1
             logger.info(f"Streaming page {page} of {schema_name}.{table_name}")
 

ddpui/tests/api_tests/test_warehouse_api.py

@@ -180,10 +180,10 @@ def test_download_warehouse_data_success(orguser):
         content = b"".join(response.streaming_content).decode("utf-8")
 
         # Assertions to verify the streaming response content
-        assert "col1,col2\n" in content  # Check header
-        assert "value1,value2\n" in content  # Check first row
-        assert "value3,value4\n" in content  # Check second row
-        assert "value5,value6\n" in content  # Check second row
+        assert "col1,col2\r\n" in content  # Check header
+        assert "value1,value2\r\n" in content  # Check first row
+        assert "value3,value4\r\n" in content  # Check second row
+        assert "value5,value6\r\n" in content  # Check second row
         assert content.count("\n") == 4