Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takes care of narrowing #22

Closed
DamienCassou opened this issue May 21, 2017 · 4 comments
Closed

Takes care of narrowing #22

DamienCassou opened this issue May 21, 2017 · 4 comments
Milestone

Comments

@DamienCassou
Copy link
Owner

beginning-of-buffer uses the beginning of the accessible part of the buffer if buffer is narrowed. I guess beginend should do the same.

It may already work properly but we should check.

@DamienCassou
Copy link
Owner Author

I have the impression that the best approach would be to go to (point-min) or (point-max) when narrowing is in effect.

@Fuco1
Copy link
Collaborator

Fuco1 commented May 25, 2017

But don't we already use point-min and point-max? That is the correct approach, they resolve to whatever is available in the current buffer narrowing.

@DamienCassou
Copy link
Owner Author

Exactly, but our code will still try to find a better beginning/end. I think it should not if the buffer is narrowed. So, my current opinion is to implement something like:

if narrowing
   execute {beginning,end}-of-buffer interactively
else
  do whatever we currently do

@DamienCassou DamienCassou added this to the v2.0.0 milestone May 25, 2017
@Fuco1
Copy link
Collaborator

Fuco1 commented May 26, 2017

Oh I see. Yes that sounds reasonable, in narrowed context you probably want to jump to the narrowing edge instead of (possibly randomly) jump somewhere else as the context assumptions might not hold there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants