Skip to content

Commit

Permalink
Change onTap to ontap to conform with lowercase action formal argumen…
Browse files Browse the repository at this point in the history
…t naming standard.
  • Loading branch information
DanChadwick committed Mar 21, 2016
1 parent 437bf47 commit d056c23
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
- [#286](https://github.com/miguelcobain/ember-paper/pull/286) paper-radio now uses `groupValue` instead of `selected`
- [#286](https://github.com/miguelcobain/ember-paper/pull/286) paper-radio now sends the action `onchange` instead of `changed` and it is mandatory (see ddau)
- [#303](https://github.com/miguelcobain/ember-paper/pull/303) paper-menu template may now specify `dense=true` to display menu items compactly
- [#313](https://github.com/miguelcobain/ember-paper/pull/313) paper-backdrop `tap` action renamed `onTap` and required action closure.
- [#313](https://github.com/miguelcobain/ember-paper/pull/313) paper-backdrop `tap` action renamed `ontap` and required action closure.

### 0.2.11

Expand Down
4 changes: 2 additions & 2 deletions addon/components/paper-backdrop.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export default Component.extend(TransitionMixin, {

_onTap(e) {
e.preventDefault();
if (this.get('onTap')) {
this.get('onTap')(e);
if (this.get('ontap')) {
this.get('ontap')(e);
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/paper-dialog.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
opaque=true
fixed=(unless parent true)
class="md-dialog-backdrop"
onTap=(action "outsideClicked")
ontap=(action "outsideClicked")
}}
{{#paper-dialog-container outsideClicked=(action "outsideClicked")}}
{{#paper-dialog-inner parent=parent openFrom=openFrom closeTo=closeTo}}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/paper-menu-container.hbs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
{{yield this}}
{{paper-backdrop class="md-menu-backdrop" onTap=(action "toggleMenu")}}
{{paper-backdrop class="md-menu-backdrop" ontap=(action "toggleMenu")}}
2 changes: 1 addition & 1 deletion app/templates/components/paper-menu-content.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
{{yield this}}
{{/paper-menu-content-pane}}
{{#ember-wormhole to="paper-wormhole"}}
{{paper-backdrop class="md-menu-backdrop" onTap=(action "toggleMenu")}}
{{paper-backdrop class="md-menu-backdrop" ontap=(action "toggleMenu")}}
{{/ember-wormhole}}
2 changes: 1 addition & 1 deletion app/templates/components/paper-select-container.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{yield this}}
{{#ember-wormhole to="paper-wormhole"}}
{{paper-backdrop class="md-select-backdrop" onTap=(action "toggleMenu")}}
{{paper-backdrop class="md-select-backdrop" ontap=(action "toggleMenu")}}
{{/ember-wormhole}}
2 changes: 1 addition & 1 deletion app/templates/components/paper-sidenav.hbs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{yield}}
{{#unless closed}}
{{#ember-wormhole to="paper-wormhole"}}
{{paper-backdrop locked-open=isLockedOpen opaque=true class="md-sidenav-backdrop" onTap=(action "toggleMenu")}}
{{paper-backdrop locked-open=isLockedOpen opaque=true class="md-sidenav-backdrop" ontap=(action "toggleMenu")}}
{{/ember-wormhole}}
{{/unless}}

0 comments on commit d056c23

Please sign in to comment.