Set 'noopener' when opening windows to avoid sharing event loops

Prevents the web UI pausing when an app opened with window.open is paused in the browsers debugger. Fixes eclipse-theia#5857.
DanTup · Dec 3, 2019 · e7e46aa · e7e46aa
1 parent 5d24847
commit e7e46aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/packages/core/src/browser/http-open-handler.ts b/packages/core/src/browser/http-open-handler.ts
@@ -35,7 +35,7 @@ export class HttpOpenHandler implements OpenHandler {
         return (uri.scheme.startsWith('http') || uri.scheme.startsWith('mailto')) ? 500 : 0;
     }
 
-    async open(uri: URI): Promise<Window | undefined> {
+    async open(uri: URI): Promise<undefined> {
         const resolvedUri = await this.externalUriService.resolve(uri);
         return this.windowService.openNewWindow(resolvedUri.toString(true), { external: true });
     }

diff --git a/packages/core/src/browser/window/default-window-service.ts b/packages/core/src/browser/window/default-window-service.ts
@@ -41,12 +41,9 @@ export class DefaultWindowService implements WindowService, FrontendApplicationC
         });
     }
 
-    openNewWindow(url: string): Window | undefined {
-        const newWindow = window.open(url);
-        if (newWindow === null) {
-            throw new Error('Cannot open a new window for URL: ' + url);
-        }
-        return newWindow;
+    openNewWindow(url: string): undefined {
+        window.open(url, undefined, 'noopener');
+        return undefined;
     }
 
     canUnload(): boolean {

diff --git a/packages/core/src/browser/window/window-service.ts b/packages/core/src/browser/window/window-service.ts
@@ -29,7 +29,7 @@ export interface WindowService {
      * In a browser, opening a new Theia tab or open a link is the same thing.
      * But in Electron, we want to open links in a browser, not in Electron.
      */
-    openNewWindow(url: string, options?: NewWindowOptions): Window | undefined;
+    openNewWindow(url: string, options?: NewWindowOptions): undefined;
 
     /**
      * Called when the `window` is about to `unload` its resources.