Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 课评编辑器在英文下溢出,导致无法点击五星 #361

Closed
w568w opened this issue Jun 24, 2024 · 2 comments · Fixed by #376
Closed

[BUG] 课评编辑器在英文下溢出,导致无法点击五星 #361

w568w opened this issue Jun 24, 2024 · 2 comments · Fixed by #376
Assignees
Labels
bug Something isn't working
Milestone

Comments

@w568w
Copy link
Member

w568w commented Jun 24, 2024

复现步骤
复现该 Bug 的步骤:

  1. 切换旦夕语言为 English;
  2. 到任何课程的课评编辑器页面;
  3. 将第一行的 Overall Rating 选为五星;
  4. 尝试在下面几行选择五星,无法选中。

原因
第一行的最后一列文字溢出,改变了单元格的宽度:

xoCh8oUkqo

@w568w w568w added the bug Something isn't working label Jun 24, 2024
@HydrogenC
Copy link
Collaborator

I have no idea why the padding between stars become so large under mobile platforms.

@w568w w568w self-assigned this Jul 1, 2024
@w568w w568w added this to the 1.4.4 milestone Jul 1, 2024
@w568w
Copy link
Member Author

w568w commented Jul 1, 2024

@HydrogenC 问题在这里:

columnSizes: [auto, 1.fr, auto],

指定列的宽度时,1.fr 代表「布局后,按此比例分配剩余空间」,auto 代表「总是尊重该子控件声称的 Intrinsic width」。

因此这样写,则显示评分项和说明的 Text 控件的宽度总是被尊重,而被设为 1.fr 的评分条,其内在宽度被无视,只能获得剩下的空间。这显然和我们需要的相反Text 控件挤一点甚至截断都无所谓,评分条必须完整展示。

反转两者后即获得相对正常的挤压效果:

图片

@w568w w568w linked a pull request Jul 1, 2024 that will close this issue
@w568w w568w closed this as completed in #376 Jul 1, 2024
@w568w w568w closed this as completed in ec46ca4 Jul 1, 2024
w568w added a commit that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants