Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #226 and upgrade dependencies (Fixed) #325

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Fix #226 and upgrade dependencies (Fixed) #325

merged 11 commits into from
Jan 3, 2024

Conversation

w568w
Copy link
Member

@w568w w568w commented Dec 21, 2023

This PR fixes #226 and upgrade dependencies.

This PR is a subsequent version of #316, containing the changes:

  • Downgrade flutter_secure_storage and encrypt_shared_preferences for now, before we found why it was broken;
  • Update to Flutter 3.16.3.

I also applied dart fix to adapt to the recently introduced super.xxx syntax.

@w568w w568w requested a review from ivanfei-1 December 21, 2023 04:39
@ivanfei-1
Copy link
Member

I will have a look as soon as the exams end.

@ivanfei-1
Copy link
Member

But why upgrading these two packages is necessary? I don't quite get it.

@w568w
Copy link
Member Author

w568w commented Dec 21, 2023

But why upgrading these two packages is necessary? I don't quite get it.

I suppose upgrading is necessary for any package. We have no special reason to stay at the old version.

@w568w w568w mentioned this pull request Jan 3, 2024
@ivanfei-1
Copy link
Member

ivanfei-1 commented Jan 3, 2024

Looks good to me. This pr can be merged.

@ivanfei-1 ivanfei-1 merged commit d5e2cdc into main Jan 3, 2024
@w568w w568w deleted the typeahead-fix branch January 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 部分设备上无法选中标签
2 participants