Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #456 #460

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: #456 #460

merged 1 commit into from
Nov 29, 2024
+25 −25

Conversation

w568w
Copy link
Member

@w568w w568w commented Nov 29, 2024

这个 PR 解决了 #456。该问题的原因是课评详情页面与论坛帖子页面不同，PagedListView 在 FutureWidget 中动态创建，build() 时可能对应的 PagedListView 根本还未创建，因此 _state 没有绑定。

该 PR 将其移动到 PagedListView 创建时的帧结束时执行。

@w568w w568w requested a review from HydrogenC November 29, 2024 11:20
@w568w w568w linked an issue Nov 29, 2024 that may be closed by this pull request
[BUG] 评教首页点击随机课评，无法跳转到正确的位置 #456
Closed
HydrogenC
HydrogenC approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@HydrogenC HydrogenC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's my mistake, I just copied the same logic from forum.

@w568w w568w merged commit 8474620 into main Nov 29, 2024
@w568w w568w deleted the fix-456 branch November 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HydrogenC HydrogenC HydrogenC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 评教首页点击随机课评，无法跳转到正确的位置
2 participants
@w568w @HydrogenC