cuba , senegal , angola , EI salvador, cameroon, italy, ireland,leben… #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, mali, malta,madagascar, Togo, Tongo counties added
|
Why do you want to add Italy and Ireland for example? It is a currency list not a country list. |
Daniel-Ioannou
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Of the currencies you added, only the Tongan paʻanga, Malagasy ariary, Angolan kwanza, and Lebanese pound are missing from the list. Please remove the rest. This is a currency picker, not a country picker. The Euro is used by 26 countries, so we cannot add the euro 26 times.
| "symbol_on_left": true | ||
| }, | ||
| { | ||
| "code": "XOF", |
There was a problem hiding this comment.
West African CFA Franc(XOF) it is already in the currency list
| "symbol_on_left": true | ||
| }, | ||
| { | ||
| "code": "USD", |
There was a problem hiding this comment.
United States Dollar (USD) it is already in the currency list
| "symbol_on_left": true | ||
| }, | ||
| { | ||
| "code": "XAF", |
There was a problem hiding this comment.
Central African CFA franc(XAF) it is already in the currency list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for the following new currencies: Cuba, Senegal, Angola, El Salvador, Cameroon, Italy, Ireland, Lebanon, Mali, Malta, Madagascar, Togo, and Tonga.
Changes Made