fix: drawable shape fade in compose #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dostalleos, thanks for opening a Pull Request. Could you please elaborate a little more on why you're fixing this alpha? Running some tests I don't see any issues with the Alpha. |
|
@DanielMartinus Unfortunately, I do not remember exactly. I think that the particles were flickering before being invisible. It was happening only when using |
|
Thanks @dostalleos. Do you remember on what device/os type this happened? |
|
@DanielMartinus Unfortunately not. But I think it was happening on all the devices we tested. |
|
When validating this fix #298 I was able to reproduce your issue when using a DrawableShape and Alpha. |
|
Fixes has been released in version 2.0.3, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
DrawableShapefade-out animation in the Compose ConfettiView.Currently, it doesn't work as expected. It juts flickers somehow.