Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit async and * in methods #1627

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix implicit async and * in methods #1627

merged 1 commit into from
Dec 2, 2024

Conversation

edemaine
Copy link
Collaborator

@edemaine edemaine commented Dec 2, 2024

Fixes #1621 by unifying implicit async/generator handling in methods with functions. Previously, methods did the implicit additions too early, during the grammar which is before async do and do* gain wrappers.

Unify implicit async/generator handling in methods with functions
Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@edemaine edemaine merged commit 2e4e51e into main Dec 2, 2024
4 checks passed
@edemaine edemaine deleted the method-revamp branch December 2, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do* works differently in top-level functions vs in methods
2 participants