Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary api rate limiter #106

Merged
merged 6 commits into from
Aug 5, 2024
Merged

dictionary api rate limiter #106

merged 6 commits into from
Aug 5, 2024

Conversation

Dankoy
Copy link
Owner

@Dankoy Dankoy commented Aug 5, 2024

Description

Added ratelimiter for external calls to dictionary api service.

Since it has limit for 450 calls in 5 minutes, I made limiter to make 15 requests in 10 seconds, which makes 450 requests in 5 minutes.

Changed build version to 0.3.0

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test full export of db. Should never get 429 error from dictionary api.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Dankoy Dankoy added the enhancement New feature or request label Aug 5, 2024
@Dankoy Dankoy self-assigned this Aug 5, 2024
@Dankoy Dankoy merged commit b459972 into main Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant