Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionaryapi is optional. #31

Merged
merged 10 commits into from
Oct 1, 2023
Merged

Dictionaryapi is optional. #31

merged 10 commits into from
Oct 1, 2023

Conversation

Dankoy
Copy link
Owner

@Dankoy Dankoy commented Oct 1, 2023

Description

On startup one can disable or enable dictionaryapi requests if it is not neseccary. Also dictionary api doesn't work with any language except english, that's why made checker of source language. If it is not en and dictionaryapy is not enabled requests to it are ignored.

Fixes #25

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test export and converter with startup keys -Dkorvo-to-anki.api.dictionaryApiEnabled=false
  • Test export and converter with source language != en

Test Configuration:

  • Firmware version: MacOS 13.6
  • Hardware: Apple M1 Pro
  • SDK: JDK-17.0.8.1-tem

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Dankoy Dankoy added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2023
@Dankoy Dankoy self-assigned this Oct 1, 2023
Copy link
Owner Author

@Dankoy Dankoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@Dankoy Dankoy merged commit 40c0e68 into main Oct 1, 2023
1 check passed
@Dankoy Dankoy deleted the dictionaryapi-optional branch October 3, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can choose what data to receive from external services
1 participant