New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Refactor widget and keyboard modules, fix crash #770

Merged

xMasterX merged 2 commits into DarkFlippers:dev from Willy-JL:js-widget-keyboard-refactor

Jun 27, 2024

Contributor

Willy-JL commented Jun 26, 2024 •

edited by xMasterX

Loading

What's new

Fixes JavaScript crashes when running widget.js from js_examples #768
Uses more lightweight ViewHolder instead of ViewDispatcher
Based on textbox and submenu refactors by nminaylov

Verification

Example widget.js and keyboard.js doesn't crash, works as intended

Checklist (For Reviewer)

PR has description of feature/bug
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix

Willy-JL added 2 commits

June 26, 2024 03:17


          JS: Refactor widget with ViewHolder, fix crash

681b1cd

Based on textbox refactor by nminaylov


          JS: Refactor keyboard with ViewHolder

8148c9b

Based on submenu refactor by nminaylov

Willy-JL requested a review from xMasterX as a code owner

June 26, 2024 01:24

Member

xMasterX commented Jun 27, 2024

Thanks!

xMasterX merged commit c93eb07 into DarkFlippers:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet