Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github actions to compile Linux builds #142

Merged

Conversation

hemebond
Copy link
Contributor

@hemebond hemebond commented Mar 4, 2024

Creates a Github action to build the Linux sdl-release executable for pull-requests and on commits to the master branch.

@hemebond
Copy link
Contributor Author

hemebond commented Mar 8, 2024

@bones-was-here All the commit information is already available via environment variables from the workflow. Could the makefile not just check and use those?

@bones-was-here
Copy link
Contributor

@bones-was-here All the commit information is already available via environment variables from the workflow. Could the makefile not just check and use those?

This method doesn't seem to support the "x commits after latest tag, also commit hash" format that the makefile obtains with git describe --always --dirty='~', ideally it would always be the same. If we decide to repaint that bikeshed it might be best as a separate job.

Going to rebase, squash, and merge.

Signed-off-by: bones_was_here <bones_was_here@xonotic.au>
@bones-was-here bones-was-here merged commit 16fb4c9 into DarkPlacesEngine:master Mar 8, 2024
1 check passed
@hemebond hemebond deleted the feature/github-actions branch March 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants