Fix for #130: Turkish ISP deletes empty UDP Packages #162
Conversation
…in the auth bytes, to purposefully increase the UDP payload size from 1 to 8 bytes, in order to pass the filtering of some ISPs.
| udpSocket.ReceiveTimeout = 0; //Reset to infinite | ||
| } | ||
|
|
||
| bool failedUdpReceive = receivedUdp != 8; |
There was a problem hiding this comment.
@4real this is a breaking change. It will stop any older versions of DR from being able to connect to the latest server which I imagine will be an issue for a lot of users.
The single byte that was there before was always intended to be a version number so that changes could be made like this one. Maybe add a new version of the auth handshake and retain support for the old version?
There was a problem hiding this comment.
Is that a real use case though? I mean, using version X server with version Y client. My impression is one quite often tries to update both client and server together because game protocols tend to be incompatible, and because of the ease of updating it's not worth maintaining backwards compatibility. Although it's true a disconnection is going to happen without a message in this case.
If there are users that need X > Y backwards compatibility (as opposed to X < Y), then single byte is good enough.
Some kind of longer DR2 + user version strings are probably a good idea anyway. Although exactly how and what to expose to the user is a bigger discussion.
There was a problem hiding this comment.
NM I see that guy's comment on Discord. So A) people have old DR2 server executables lingering around which must be accounted for, and B) there I should probably update the "compatibility"/"legacy" listener whatever it's called to make sure it also runs.
Decided to send the auth token again rather than a fixed 5 byte message. Cost is minimal after all.